> On 2012-03-08 23:06:09, Mona Chitnis wrote:
> > trunk/core/src/test/resources/coord-multiple-output-instance4.xml, line 38
> > <https://reviews.apache.org/r/4222/diff/2/?file=89137#file89137line38>
> >
> > Aren't these 2 instances?
Also, can a test be added for coord:dateOffset('String strBaseDate', 'int
offset', 'String unit')? Thanks
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4222/#review5757
-----------------------------------------------------------
On 2012-03-08 15:08:40, Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4222/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 15:08:40)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> checkMultipleTimeInstances doesn't work for EL extensions. EX:
> ${coord:formatTime(coord:current(0),'yyyy-MM-dd')}
>
>
> This addresses bug OOZIE-675.
> https://issues.apache.org/jira/browse/OOZIE-675
>
>
> Diffs
> -----
>
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
> 1297367
> trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java 1297367
>
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
> 1297367
> trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1297367
> trunk/core/src/test/resources/coord-multiple-output-instance4.xml
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4222/diff
>
>
> Testing
> -------
>
> * New test case added to TestCoordSubmitXCommand.java for verifying the
> changes
> * Added additional test cases to TestELEvaluator.java as well
>
>
> Thanks,
>
> Srikanth
>
>
