----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review6087 -----------------------------------------------------------
Overall pls check the oozie formatting. Looks like there are some changes that are not related to this. trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment13062> We can break the loop here. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment13063> remove this line. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment13065> This could be a boolean value that will remove the "SUPPORT_MULTICLUSTER_ON" variable trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment13064> Why are we hard-coding the "JavaActionExecutor"? trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment13066> why this many line? please use the oozie-formatting. trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment13067> I think int he new code "group.name" is removed from all over. trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment13068> same for 'group' trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment13069> extra space trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java <https://reviews.apache.org/r/2059/#comment13070> formatting all over trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java <https://reviews.apache.org/r/2059/#comment13071> why these new two imports? - Mohammad On 2012-03-09 02:36:56, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2012-03-09 02:36:56) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch was originally worked on by Mayank Bansal. > I (Mona Chitnis) am in charge of handling this review request. > > Description - adding hadoop.next support for oozie > > > This addresses bug OOZIE-477. > https://issues.apache.org/jira/browse/OOZIE-477 > > > Diffs > ----- > > trunk/core/src/main/resources/oozie-default.xml 1298499 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1298499 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1298499 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java > 1298499 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1298499 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1298499 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1298499 > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1298499 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1298499 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
