> On 2012-03-23 20:46:30, Alejandro Abdelnur wrote: > > the FSActionExecutor is checking for the allowed filesystem schemes. It > > seems the JavaActionExecutor and the submit job command should do the same, > > no?
In earlier code, the FsActionExecutor had hardcoding of "hdfs://" scheme. This patch is mainly directed to remove that hardcoding and allow flexibility in schemes, through configuration. There can be other places too, in addition to JavaActionExecutor where code change is required for federation. I am opening another JIRA to address that requirement. > On 2012-03-23 20:46:30, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java, > > line 97 > > <https://reviews.apache.org/r/2059/diff/6/?file=94571#file94571line97> > > > > this is a non-relevant change. please revert ok > On 2012-03-23 20:46:30, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java, > > line 102 > > <https://reviews.apache.org/r/2059/diff/6/?file=94571#file94571line102> > > > > same same ok > On 2012-03-23 20:46:30, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, > > line 98 > > <https://reviews.apache.org/r/2059/diff/6/?file=94568#file94568line98> > > > > we should read/parse/trim the supported filesystem schemes once (at > > init time, or first time) and then cache the array agreed. otherwise the config property - supported schemes, is being retrieved repeatedly. fixed. > On 2012-03-23 20:46:30, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 1114 > > <https://reviews.apache.org/r/2059/diff/6/?file=94569#file94569line1114> > > > > where is this method used? removing method since it is not used. - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review6307 ----------------------------------------------------------- On 2012-03-22 17:27:37, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2012-03-22 17:27:37) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch was originally worked on by Mayank Bansal. > I (Mona Chitnis) am in charge of handling this review request. > > Description - adding hadoop.next support for oozie > > > This addresses bug OOZIE-477. > https://issues.apache.org/jira/browse/OOZIE-477 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1303609 > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1303609 > trunk/core/src/main/resources/oozie-default.xml 1303609 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1303609 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
