[
https://issues.apache.org/jira/browse/OOZIE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264015#comment-13264015
]
[email protected] commented on OOZIE-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4755/#review7328
-----------------------------------------------------------
The OozieDBCLI tool may require some changes to ensure the DB is
created/upgraded on the right schema.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
<https://reviews.apache.org/r/4755/#comment16185>
the patch has a few trailing spaces/tabs
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
<https://reviews.apache.org/r/4755/#comment16184>
oozie.db.schema.name renaming to oozie.db.name is missed in the default
value.
Furthermore, there are a few *-site.xml files in oozie test/resources dirs
(core & examples) that may be using oozie.db.schema.name.
To make it easier, why not leave oozie.db.schema.name untouch?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
<https://reviews.apache.org/r/4755/#comment16183>
why not just using 'dbSchema.length() >0' ?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/4755/#comment16186>
why keeping both oozie.db.name and oozie.db.schema.name?
- Alejandro
On 2012-04-17 10:39:44, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4755/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-17 10:39:44)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie's JPA service doesn't support configure different schemas for
oozie's db.
bq. Our company wants to use one db for multi oozie clusters, and then we want
each oozie cluster can use different schema of the db. Therefore JPAService in
oozie should support to configure the schema of the db, not just the database.
bq. The oozie.db.schema.name is use to configure oozie's db name, however, it
is a little confusing for it is not used to configure the actually schema of db.
bq.
bq.
bq. This addresses bug OOZIE-814.
bq. https://issues.apache.org/jira/browse/OOZIE-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml
1327027
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
1327027
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
1327027
bq.
bq. Diff: https://reviews.apache.org/r/4755/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Deployed Oozie, added oozie.db.schema.name configs values, succeed to
run the examples on Derby and Postgres databases.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Add support of configuring db's schema in JPAService for oozie
> --------------------------------------------------------------
>
> Key: OOZIE-814
> URL: https://issues.apache.org/jira/browse/OOZIE-814
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 3.2.0, trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Oozie's JPA service doesn't support configure different schemas for oozie's
> db.
> Our company wants to use one db for multi oozie clusters, and then we want
> each oozie cluster can use different schema of the db. Therefore JPAService
> in oozie should support to configure the schema of the db, not just the
> database.
> The oozie.db.schema.name is use to configure oozie's db name, however, it is
> a little confusing for it is not used to configure the actually schema of db.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
