[
https://issues.apache.org/jira/browse/OOZIE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272514#comment-13272514
]
[email protected] commented on OOZIE-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4755/#review7779
-----------------------------------------------------------
Looks good, I've made some comments inline.
In addition:
* I don't see the different oozie-site.xml for testing for different DBs being
updated, is it not required?
After your feedback I'll take the patch for a spin doing upgrades and creation
tests. BTW, have you done that?
Thanks, nice work.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/4755/#comment17087>
please fix the indentation of these 3 classes
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/4755/#comment17088>
indentation fix
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/4755/#comment17089>
indentation fix
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/4755/#comment17090>
indentation fix
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/4755/#comment17086>
you need to leave a space as value, else the value will be NULL. Looking
at the code it really does not matter. So, this is just a minor NIT
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/AG_Install.twiki
<https://reviews.apache.org/r/4755/#comment17091>
we should add here the oozie.db.schema.name property with the default
value, right?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
<https://reviews.apache.org/r/4755/#comment17093>
we should trim the value obtained from the conf.get() here
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
<https://reviews.apache.org/r/4755/#comment17096>
can we please leave the names of table and columns with the case defined in
the bean as they where before? else we could run into issues when a DB is case
sensitive for table/column names.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
<https://reviews.apache.org/r/4755/#comment17097>
why is this being remove? OpenJPA doe not do this as part of an upgrade,
that is why this is here
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
<https://reviews.apache.org/r/4755/#comment17098>
trim value of conf.get()
- Alejandro
On 2012-05-09 02:36:58, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4755/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 02:36:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie's JPA service doesn't support configure different schemas for
oozie's db.
bq. Our company wants to use one db for multi oozie clusters, and then we want
each oozie cluster can use different schema of the db. Therefore JPAService in
oozie should support to configure the schema of the db, not just the database.
bq. The oozie.db.schema.name is use to configure oozie's db name, however, it
is a little confusing for it is not used to configure the actually schema of db.
bq.
bq.
bq. This addresses bug OOZIE-814.
bq. https://issues.apache.org/jira/browse/OOZIE-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/SystemInfoBean.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/AG_Install.twiki
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/utils/dbutils/updatescripts/readme.txt
1335881
bq.
bq. Diff: https://reviews.apache.org/r/4755/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Deployed Oozie, added oozie.db.schema.name configs values, succeed to
run the examples on Derby and Postgres databases.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Add support of configuring db's schema in JPAService for oozie
> --------------------------------------------------------------
>
> Key: OOZIE-814
> URL: https://issues.apache.org/jira/browse/OOZIE-814
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 3.2.0, trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Oozie's JPA service doesn't support configure different schemas for oozie's
> db.
> Our company wants to use one db for multi oozie clusters, and then we want
> each oozie cluster can use different schema of the db. Therefore JPAService
> in oozie should support to configure the schema of the db, not just the
> database.
> The oozie.db.schema.name is use to configure oozie's db name, however, it is
> a little confusing for it is not used to configure the actually schema of db.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
