[
https://issues.apache.org/jira/browse/OOZIE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273017#comment-13273017
]
[email protected] commented on OOZIE-814:
-----------------------------------------------------
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. > Looks good, I've made some comments inline.
bq. >
bq. > In addition:
bq. >
bq. > * I don't see the different oozie-site.xml for testing for different DBs
being updated, is it not required?
bq. >
bq. > After your feedback I'll take the patch for a spin doing upgrades and
creation tests. BTW, have you done that?
bq. >
bq. > Thanks, nice work.
bq. >
I don't see the different oozie-site.xml for testing for different DBs being
updated, is it not required?
-- You mean why there is not a "oozie.db.schema.name" property in
oozie-site.xml? It is not requried, and if any wants to specify the schema, he
must configure it. if not, the database will choose the default schema itself.
After your feedback I'll take the patch for a spin doing upgrades and creation
tests. BTW, have you done that?
-- Yes, i am sure you would not feel bothering when you test with this patch.
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml,
line 34
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107962#file107962line34>
bq. >
bq. > please fix the indentation of these 3 classes
ok
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml,
line 91
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107962#file107962line91>
bq. >
bq. > indentation fix
ok
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml,
line 148
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107962#file107962line148>
bq. >
bq. > indentation fix
ok
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml,
line 205
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107962#file107962line205>
bq. >
bq. > indentation fix
ok
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml,
line 1002
bq. >
<https://reviews.apache.org/r/4755/diff/2/?file=107963#file107963line1002>
bq. >
bq. > you need to leave a space as value, else the value will be NULL.
Looking at the code it really does not matter. So, this is just a minor NIT
take it, :D
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/AG_Install.twiki,
line 119
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107964#file107964line119>
bq. >
bq. > we should add here the oozie.db.schema.name property with the
default value, right?
There is no need. Databases differ in their default shema, that of postgres is
public and of derby is APP.
Database will choose the default schema itselt, if it is not specified.
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java,
line 169
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107965#file107965line169>
bq. >
bq. > we should trim the value obtained from the conf.get() here
ok
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java,
line 236
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107965#file107965line236>
bq. >
bq. > can we please leave the names of table and columns with the case
defined in the bean as they where before? else we could run into issues when a
DB is case sensitive for table/column names.
i don't want to add the schema to each sql, that's why i take the jpa. And also
for this reason, we should use the JPA Query so that jpa will add the schema
auto in each query.
i not sure i have understood you question, i wish the reply is that you wonder.
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java,
line 320
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107965#file107965line320>
bq. >
bq. > why is this being remove? OpenJPA doe not do this as part of an
upgrade, that is why this is here
I'm sorry, i made a serious mistake here. This part is recovered with little
change in the new patch.
bq. On 2012-05-10 17:21:37, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java,
line 645
bq. > <https://reviews.apache.org/r/4755/diff/2/?file=107965#file107965line645>
bq. >
bq. > trim value of conf.get()
ok
- Han
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4755/#review7779
-----------------------------------------------------------
On 2012-05-09 02:36:58, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4755/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 02:36:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie's JPA service doesn't support configure different schemas for
oozie's db.
bq. Our company wants to use one db for multi oozie clusters, and then we want
each oozie cluster can use different schema of the db. Therefore JPAService in
oozie should support to configure the schema of the db, not just the database.
bq. The oozie.db.schema.name is use to configure oozie's db name, however, it
is a little confusing for it is not used to configure the actually schema of db.
bq.
bq.
bq. This addresses bug OOZIE-814.
bq. https://issues.apache.org/jira/browse/OOZIE-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/SystemInfoBean.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/AG_Install.twiki
1335881
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/utils/dbutils/updatescripts/readme.txt
1335881
bq.
bq. Diff: https://reviews.apache.org/r/4755/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Deployed Oozie, added oozie.db.schema.name configs values, succeed to
run the examples on Derby and Postgres databases.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Add support of configuring db's schema in JPAService for oozie
> --------------------------------------------------------------
>
> Key: OOZIE-814
> URL: https://issues.apache.org/jira/browse/OOZIE-814
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 3.2.0, trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Oozie's JPA service doesn't support configure different schemas for oozie's
> db.
> Our company wants to use one db for multi oozie clusters, and then we want
> each oozie cluster can use different schema of the db. Therefore JPAService
> in oozie should support to configure the schema of the db, not just the
> database.
> The oozie.db.schema.name is use to configure oozie's db name, however, it is
> a little confusing for it is not used to configure the actually schema of db.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
