----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4842/#review7673 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/4842/#comment16899> this IF should also check that the action status is WAITING or READY if (!time-AFTER && (action WAITING || READY)) trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/4842/#comment16901> we should remove this IF/exception here. see comment above where the check would go. we don't want to throw an exception we just want to make sure we don't delete and action that is already in progress. - Alejandro On 2012-05-04 07:40:58, shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4842/ > ----------------------------------------------------------- > > (Updated 2012-05-04 07:40:58) > > > Review request for oozie. > > > Summary > ------- > > CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit > while calculating the action times. So, if the frequency is > non-minutes(hours, days, months), setting pause time can delete past coord > actions > > > This addresses bug OOZIE-818. > https://issues.apache.org/jira/browse/OOZIE-818 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 1329080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 1329080 > > Diff: https://reviews.apache.org/r/4842/diff > > > Testing > ------- > > UT - TestCoordChangeXCommand > > > Thanks, > > shwethags > >
