-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7775
-----------------------------------------------------------
I like the approach, minor corrections through out the patch.
I've applied the patch and run into 2 issues:
* NIT: patch is done at trunk/core level, it should be done a trunk/ level
* Test errors:
Results :
Failed tests:
testCoordActionDelete(org.apache.oozie.command.coord.TestCoordChangeXCommand):
Error code should be E1022
Tests in error:
testCoordChangePauseTime(org.apache.oozie.command.coord.TestCoordChangeXCommand):
E0603: SQL error in operation [java.lang.ClassCastException:
[Ljava.lang.Object; cannot be cast to java.lang.String], {1}
Tests run: 4, Failures: 1, Errors: 1, Skipped: 0
Once this is taken care it is should ready for +1
Thanks for all the work.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17079>
getLastActionTime() seems abetter name, 'actual' may give some connotation
to when the action is running and actually this is the nominal time of the
action.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17077>
trailing spaces
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17078>
trailing spaces
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17080>
trailing spaces
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17081>
trailing spaces
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17082>
trailing spaces
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17083>
trailing spaces
- Alejandro
On 2012-05-10 09:09:35, shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4842/
> -----------------------------------------------------------
>
> (Updated 2012-05-10 09:09:35)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
> while calculating the action times. So, if the frequency is
> non-minutes(hours, days, months), setting pause time can delete past coord
> actions
>
>
> This addresses bug OOZIE-818.
> https://issues.apache.org/jira/browse/OOZIE-818
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
> 1335944
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
> 1335944
>
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
> 1335944
>
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
> 1335944
>
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
> 1335944
>
> Diff: https://reviews.apache.org/r/4842/diff
>
>
> Testing
> -------
>
> UT - TestCoordChangeXCommand
>
>
> Thanks,
>
> shwethags
>
>
