----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4842/#review7935 -----------------------------------------------------------
Ship it! Shwetha, gr8 job, thxs for your patience! it took me a while because I wanted to ensure we would not run into a race-condition/deadlock while deleting coord actions. it is not possible because coordinator commands lock on the coordinator job id. I'll commit this to trunk, would you please upload the final patch to JIRA and grant license rights? - Alejandro On 2012-05-12 11:36:34, shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4842/ > ----------------------------------------------------------- > > (Updated 2012-05-12 11:36:34) > > > Review request for oozie. > > > Summary > ------- > > CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit > while calculating the action times. So, if the frequency is > non-minutes(hours, days, months), setting pause time can delete past coord > actions > > > This addresses bug OOZIE-818. > https://issues.apache.org/jira/browse/OOZIE-818 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1337043 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 1337043 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java > 1337043 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 1337043 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java > 1337043 > > Diff: https://reviews.apache.org/r/4842/diff > > > Testing > ------- > > UT - TestCoordChangeXCommand > > > Thanks, > > shwethags > >
