[
https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271208#comment-13271208
]
[email protected] commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-08 06:50:32, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java,
line 242
bq. > <https://reviews.apache.org/r/4842/diff/2/?file=106729#file106729line242>
bq. >
bq. > we should remove this IF/exception here. see comment above where the
check would go. we don't want to throw an exception we just want to make sure
we don't delete and action that is already in progress.
bq.
bq. Alejandro Abdelnur wrote:
bq. Shwetha, good point I was missing that. This means the change has to
fail, would you mind reworking your patch to throw the exception in a check
following line 210 outside of the delete? It seems it belongs there more than
within the delete method.
bq.
bq. THX
I have updated the diff by moving action status check to
processLookaheadActions. But even this will not guard against race condition.
Consider this:
thr1- check action status
thr2 - make action running
thr1 - delete action
and we will end up deleting running action!
This check should go in the sql
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7673
-----------------------------------------------------------
On 2012-05-09 07:59:18, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 07:59:18)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
while calculating the action times. So, if the frequency is non-minutes(hours,
days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
1335944
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java
1335944
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
1335944
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java
1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
> while calculating the action times. So, if the frequency is
> non-minutes(hours, days, months...), setting pause time can delete past coord
> actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
