[
https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271902#comment-13271902
]
[email protected] commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7747
-----------------------------------------------------------
regarding the race condition scenario you mentioned, you are correct.
I wonder what would be the correct way of doing it?
* collect all action IDs to delete, obtain (oozie lock service) lock for them,
check status of all actions, then delete them, if lock cannot be acquired or
status does not match anymore, rollback. (But we should do this as part of
another JIRA)
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17049>
do we really need the loadAction/deleteAction methods or can we do this
inline above?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17050>
This executor is missleading, it is returning a CoordinatorAction which
only has it status set.
Why not make it return the action status instead? (i know, this was not
fully done in the JIRA, but his is nasty)
- Alejandro
On 2012-05-09 07:59:18, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 07:59:18)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
while calculating the action times. So, if the frequency is non-minutes(hours,
days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
1335944
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java
1335944
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
1335944
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java
1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
> while calculating the action times. So, if the frequency is
> non-minutes(hours, days, months...), setting pause time can delete past coord
> actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
