Hi, Mike. Thank you for your patch. >I do not want to add a login log message to the iscsid_req_* functions >because they are generic and could be used for any operation.
Yes, that's perfectly right idea. That should be bettet than my patch. I tried your patch, but that still does not output login-success message when calling iscsid_req_by_rec. It seems that log_login_msg() would not be called in either login_portal() or iscsid_logout_reqs_wait() when iscsid_req_by_rec returns success. I probably missed something. I will look at it tomorrow again. So, don't be bothered with my question. Thanks. Kim 2009/11/17, Mike Christie <micha...@cs.wisc.edu>: > Yangkook Kim wrote: >> >> No2, outputting login success message even when calling >> iscsid_req_by_rec(). >> > > To fix this, how about the attached patch made over the open-iscsi git tree? > > I do not want to add a login log message to the iscsid_req_* functions > because they are generic and could be used for any operation. This patch > moves the log message you were adding to iscsiadm.c. > > I also fixed up the logout side since that had the same issue. > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to email@example.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---