Thanks for your patch. I tested your patch and it worked fine.
So, next you will upload this patch to the git tree and the patch will become the part of source code in the next release of open-iscsi. Is my understanding correct? I am asking this question because I just want to know the normal development process of this and other linux project. 2009/11/24, Mike Christie <micha...@cs.wisc.edu>: > Mike Christie wrote: >> Yangkook Kim wrote: >>> Hi, Mike. Thank you for your patch. >>> >>>> I do not want to add a login log message to the iscsid_req_* functions >>>> because they are generic and could be used for any operation. >>> Yes, that's perfectly right idea. That should be bettet than my patch. >>> >>> I tried your patch, but that still does not output login-success >>> message when calling >>> iscsid_req_by_rec. >>> >>> It seems that log_login_msg() would not be called in either >>> login_portal() or >>> iscsid_logout_reqs_wait() when iscsid_req_by_rec returns success. >>> >>> I probably missed something. I will look at it tomorrow again. >>> >> >> Nope. You are right. Nice catch. I messed up. I was only concentrating >> on the error paths. I will fix up my patch and resend. Thanks. >> > > > Here is a corrected patch. > > -- > > You received this message because you are subscribed to the Google Groups > "open-iscsi" group. > To post to this group, send email to open-is...@googlegroups.com. > To unsubscribe from this group, send email to > open-iscsi+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/open-iscsi?hl=. > > > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
