This looks to be a bug where tgt is being dereferenced prior to the
existence check.

On Fri, 2012-11-30 at 07:16 -0500, [email protected] wrote:
> +static int qla4xxx_sysfs_ddb_is_non_persistent(struct device *dev,
> void *data)
> +{
> +       struct iscsi_flash_tgt *tgt = iscsi_dev_to_flash_tgt(dev);
> +       struct ddb_sysfs_entry *ddb_sysfs = tgt->dd_data;
> +       int *valid_cookie = data;
> +
> +       if (!iscsi_is_flash_tgt_dev(dev))
> +               return 0;
> +
> +       tgt = iscsi_dev_to_flash_tgt(dev);
> +       ddb_sysfs = tgt->dd_data;
> +
> +       return !(ddb_sysfs->fw_ddb.cookie == *valid_cookie);
> +}


-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.

Reply via email to