-----Original Message----- From: Eddie Wai <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Friday 11 January 2013 6:32 AM To: "[email protected]" <[email protected]> Cc: Mike Christie <[email protected]>, Vikas <[email protected]>, Lalit Chandivade <[email protected]>, Ravi Anand <[email protected]>, Poornima Vonti <[email protected]>, Manish Rangankar <[email protected]>, Adheer Chandravanshi <[email protected]> Subject: Re: [RFC_V3 PATCH 2/2] qla4xxx: Add flash target mgmt support through sysfs.
>This looks to be a bug where tgt is being dereferenced prior to the >existence check. > >On Fri, 2012-11-30 at 07:16 -0500, [email protected] wrote: >> +static int qla4xxx_sysfs_ddb_is_non_persistent(struct device *dev, >> void *data) >> +{ >> + struct iscsi_flash_tgt *tgt = iscsi_dev_to_flash_tgt(dev); >> + struct ddb_sysfs_entry *ddb_sysfs = tgt->dd_data; >> + int *valid_cookie = data; >> + >> + if (!iscsi_is_flash_tgt_dev(dev)) >> + return 0; >> + >> + tgt = iscsi_dev_to_flash_tgt(dev); >> + ddb_sysfs = tgt->dd_data; >> + >> + return !(ddb_sysfs->fw_ddb.cookie == *valid_cookie); >> +} We fix this issue in updated patch send on open-iscsi list today. Thanks for pointing out this. -Vikas. ________________________________ This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
