On 1/29/14 1:51 PM, Hannes Reinecke wrote:


On 01/29/2014 07:27 PM, Eddie Wai wrote:
The patchset works great on my system.  Forcing an autoreconf and
untrack all autogen files makes sense.  Thanks for the work.

Although I would be more inclined to put all .gitignore entries into a
single .gitignore file in the trunk, separating them out is fine too.

That's what I've tried, but somehow git would like it. Hence the split.

There's actually an error in the autoconf files, which I discovered
later during testing; in iscsiuio/src/uip/Makefile.am the statement

lib_iscsi_uip_a_CFLAGS =

is missing an $(AM_CFLAGS).
Should I send an incremental patch or re-do the patchset?


Don't worry about it. I just did a patch on top of your set.

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to