On Tue, Feb 09, 2016 at 03:24:04PM -0800, Chris Leech wrote:
> But there may be more straightforward gains to be had in cleaning up the
> sysfs code.  Every attribute read ends up in sysfs_lookup_devpath_by_subsys_id
> which does a bunch of string ops and stats trying to find the device
> path.  Even keeping the subsystem location general as it is, if we find
> things once and remember the path for all the attribute reads it should
> help a lot.

On the right track but that still wasn't exactly the big issue.
It's the attribute cache.  It grows without bounds, and the lookup is
just a linear walk through a linked list with a strcmp against each
node.

- Chris

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to