>>> Chris Leech <cle...@redhat.com> schrieb am 10.02.2016 um 03:53 in Nachricht
<20160210025324.gb9...@straylight.hirudinean.org>:
> On Tue, Feb 09, 2016 at 03:24:04PM -0800, Chris Leech wrote:
>> But there may be more straightforward gains to be had in cleaning up the
>> sysfs code.  Every attribute read ends up in 
> sysfs_lookup_devpath_by_subsys_id
>> which does a bunch of string ops and stats trying to find the device
>> path.  Even keeping the subsystem location general as it is, if we find
>> things once and remember the path for all the attribute reads it should
>> help a lot.
> 
> On the right track but that still wasn't exactly the big issue.
> It's the attribute cache.  It grows without bounds, and the lookup is
> just a linear walk through a linked list with a strcmp against each
> node.

A linear search in a "cache" sounds like a bad idea anyway: Why not do some 
hashing?

> 
> - Chris
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "open-iscsi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to open-iscsi+unsubscr...@googlegroups.com.
> To post to this group, send email to open-iscsi@googlegroups.com.
> Visit this group at https://groups.google.com/group/open-iscsi.
> For more options, visit https://groups.google.com/d/optout.




-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to