On 11/30/22 5:05 PM, Lee Duncan wrote: > On 11/30/22 12:08, Mike Christie wrote: >> On 11/30/22 1:53 PM, Lee Duncan wrote: >>> Have you already worked on the open-iscsi side of this? No reason for >>> duplicate development. >> >> I think you missed his reply where he said he was missed the >> iscsid.safe_logout setting. >> >> >> > > No, I saw that, but I thought there were some cases that might be missed by > checking for mounts. I also think having to set "safe" mode globally is > inefficient, but that's a separate issue.
The safe logout code also checks for holders which covers things like lvm and raid use. It doesn't handle things like general device openings though. Maybe we want a general block layer use count file for that if we are worried about that type of thing. > > Was the plan to retrace the changes submitted and accepted upstream for > adding a sysfs entry for node_startup that won't be used? Or is the plan to > populate that attribute for user consumption, even though it isn't needed for > this particular problem? Are you asking about the patch in this thread? If so, I don't think it's merged. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/905da4a0-3ecb-9bb9-75f3-79f7be19599b%40oracle.com.
