[
https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476736
]
Patrick Linskey commented on OPENJPA-160:
-----------------------------------------
> 1. I really think we're going just a bit too fast here. I wasn't able to
> comment
> on the discussion because I've been in meetings all morning, and it's really
> tough to find the issue resolved, a patch committed, and I never had a
> chance.
> I also notice that just minutes after the commit, Abe had a comment that
> resulted in another change. For issues that attract this kind of attention, I
> think a little more time is probably needed to reach closure.
IIRC, we're operating in a commit-then-review mode in OpenJPA. This issue has
been very experimental by nature up earlier today, so I was providing patches
to find something that worked. Once we got there, I committed, Abe reviewed, we
changed it. Seems pretty much exactly like how we've handled other issues,
except that we did a bunch of code-collaboration along the way.
> 2. I'd like to reopen the discussion of which BrokerImpl should be the
> default.
> In general, I like performance options to be the default. It makes the "out
> of
> the box" experience better because users don't need to find, much less read,
> the relevant part of the documentation. Well-behaved applications don't need
> the finalizer. Small applications running in short-lived vms don't need it.
Personally, I prefer more forgiving defaults when possible, so that people
don't get bitten when they're just playing around with things. Also, if we
decide to change our defaults, I think that we should include
openjpa.DataCache, openjpa.QueryCache, and possibly other things listed in the
optimization guide in such a change.
Any other opinions?
> Reuse BrokerImpl objects
> ------------------------
>
> Key: OPENJPA-160
> URL: https://issues.apache.org/jira/browse/OPENJPA-160
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Michael Dick
> Assigned To: Patrick Linskey
> Attachments: newprofile.jpg, openjpa-160-clone-patch.txt,
> openjpa-160-finalization-and-cloning-patch.txt, openjpa-160-patch.txt,
> openjpa-160-patch.txt, openjpa-160-patch.txt, openjpa-160-patch.txt,
> perf2.jpg, perf3.jpg, profile_clonepatch.jpg, profile_explicitclass.jpg
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
