Patrick Linskey commented on OPENJPA-160:

> The extra day would have allowed Abe to get his comments recognized 
> and Craig would have been able to voice his "default action" concern.

I guess I fail to see the problem. Craig has voiced his "default action" 
concern, and Abe did get his comments recognized. IMO, the real issue here is 
whether we want to do review-then-commit or commit-then-review. Unless there is 
some known way to say "this issue needs to be review-then-commit", this problem 
will just keep on repeating itself. 

Personally, I like to get changes off of my local machine and into svn as soon 
as I can, as I've found that letting changes linger is problematic.

Remember that (modulo svn's issues with David's checkin) we have history here. 
Just checking something in doesn't mean that it's necessarily done.

> But, having good performance out of the box is a benefit -- not only for the 
> customer, but also for all of us so that we don't have to explain why we're 
> "protecting" the customer from him/herself.

It's worth noting that in this situation, it's not a performance issue per se, 
but rather a scalability issue, since it only crops up under heavily-concurrent 
usage patterns. I'd expect that anyone doing that type of coding and not using 
an appserver would be reading through the optimization guide in detail.

Which brings up an interesting possibility: we could set the value differently 
if the entry point is from 
PersistenceProvider.createContainerEntityManagerFactory(), since an appserver 
really really should be managing resources correctly.

> Reuse BrokerImpl objects
> ------------------------
>                 Key: OPENJPA-160
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-160
>             Project: OpenJPA
>          Issue Type: Sub-task
>            Reporter: Michael Dick
>         Assigned To: Patrick Linskey
>         Attachments: newprofile.jpg, openjpa-160-clone-patch.txt, 
> openjpa-160-finalization-and-cloning-patch.txt, openjpa-160-patch.txt, 
> openjpa-160-patch.txt, openjpa-160-patch.txt, openjpa-160-patch.txt, 
> perf2.jpg, perf3.jpg, profile_clonepatch.jpg, profile_explicitclass.jpg

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to