Hi Pallavi
Looks good to me.
-Mei
From: Mathew, Pallavi
Sent: Friday, June 10, 2011 9:18 AM
To: Ye, Mei; open64-devel@lists.sourceforge.net
Subject: RE: Code review request for vectorizer patch
Hi Mei,
Please see the attached updated and re-tested patch.
For 1) Declarations moved to lnoutils.h.
For 2) Added check on def_list.
For 3) The input nest is not necessarily perfectly nested. It is simply nested.
i.e. The loop we are examining if a loop of a SNL. If <wn> is in the imperfect
part of <loop> it will be distributed when the outer loop is shifted into the
inner-most position, but if it is in the init/start/end/step constructs, it
will remain inside <loop>. See the updated simplified definition of function
'Is_WN_Inside_Loop' with improved comments to explain its functionality.
Thanks.
Pallavi
From: Ye, Mei
Sent: Monday, June 06, 2011 12:23 PM
To: Mathew, Pallavi; open64-devel@lists.sourceforge.net
Subject: RE: Code review request for vectorizer patch
- L10,11,36: Can these declaration be placed in a .h file like "lnopt_main.h"
that is included by most of the LNO .cxx files?
- L196: do you handle the case that the "def_list" is incomplete?
- L136: if <wn> is in the loop body of <loop>, but outside of <innermost>, will
it be
out of the loop when the <loop> shifts to the innermost position?
OR: Is it TRUE that this will not happen since all loops are perfectly
nested at this point?
From: Mathew, Pallavi [mailto:pallavi.mat...@amd.com]
Sent: Thursday, June 02, 2011 3:15 PM
To: open64-devel@lists.sourceforge.net
Subject: [Open64-devel] Code review request for vectorizer patch
Hi,
Can a gatekeeper please review the attached vectorizer patch that
moves the vectorizable loop to the innermost position. This optimization
is disabled by default and can be enabled via -LNO:loop_model_simd=on.
Thanks.
Pallavi
------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
