Looks good, thx.
-Mei
From: Mathew, Pallavi
Sent: Tuesday, May 24, 2011 11:32 AM
To: Ye, Mei; open64-devel@lists.sourceforge.net
Subject: RE: Code review request for vectorizer patch
Hi Mei,
Please see the attached revised and re-tested patch.
For comment 1: I agree with the suggested change and that it should be deferred
to a separate patch.
For comments 2 and 3: Change incorporated in the attached patch.
Also in the updated patch, the earlier change to lwn_util.h is backed out as
that was only for debugging purposes.
Thanks.
-Pallavi
From: Ye, Mei
Sent: Wednesday, May 18, 2011 4:51 PM
To: Mathew, Pallavi; open64-devel@lists.sourceforge.net
Subject: RE: Code review request for vectorizer patch
- "Remove_Unity_Trip_Loop" returns two values, use "std::pair" instead. Sun
will like this change :-). However this function has been widely called
throughout LNO, so it could be defered as a separated task.
- L144, 149, 151, "WN_end(remainder)" can be CSEed.
- L187: The lifetime of "stack" is transient, can "LNO_local_pool" be used?
"stack" can also be "CXX_DELETE" after its lifetime ends.
From: Mathew, Pallavi [mailto:pallavi.mat...@amd.com]
Sent: Wednesday, May 18, 2011 12:29 PM
To: open64-devel@lists.sourceforge.net
Subject: [Open64-devel] Code review request for vectorizer patch
Hi,
The attached vectorizer patch tries to remove the SIMD remainder loop
construct. It handles two cases:
1. If the remainder loop has exactly one iteration, remove the loop construct
(the loop body remains, of course).
2. If the remainder loop has at most one iteration, replace the loop
construct with if-construct
The patch also adds flag -LNO:simd_rm_unity_remainder={on|off} to guard these
changes. By default, the flag is off.
Can a gatekeeper please review?
Thanks.
Pallavi
------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery,
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now.
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
