I hope people do agree that if a function returns 2 values, using "pair" is a much better interface in terms of clarity and simpler flow. As compiler people, it should also be clear that sort of building the program with IPA, using "pair" instead of passing &ret_val provides much better optimization opportunity across the board. :-) Sun
On Thu, May 19, 2011 at 7:51 AM, Ye, Mei <mei...@amd.com> wrote: > - "Remove_Unity_Trip_Loop" returns two values, use "std::pair" instead. > Sun will like this change :-). However this function has been widely > called throughout LNO, so it could be defered as a separated task. > > - L144, 149, 151, "WN_end(remainder)" can be CSEed. > > - L187: The lifetime of "stack" is transient, can "LNO_local_pool" be used? > "stack" can also be "CXX_DELETE" after its lifetime ends. > > > > From: Mathew, Pallavi [mailto:pallavi.mat...@amd.com] > Sent: Wednesday, May 18, 2011 12:29 PM > To: open64-devel@lists.sourceforge.net > Subject: [Open64-devel] Code review request for vectorizer patch > > > > Hi, > > The attached vectorizer patch tries to remove the SIMD remainder loop > construct. It handles two cases: > > 1. If the remainder loop has exactly one iteration, remove the loop > construct (the loop body remains, of course). > > 2. If the remainder loop has at most one iteration, replace the loop > construct with if-construct > > > > The patch also adds flag -LNO:simd_rm_unity_remainder={on|off} to guard > these changes. By default, the flag is off. > > > > Can a gatekeeper please review? > > > > Thanks. > > Pallavi > > ------------------------------------------------------------------------------ > What Every C/C++ and Fortran developer Should Know! > Read this article and learn how Intel has extended the reach of its > next-generation tools to help Windows* and Linux* C/C++ and Fortran > developers boost performance applications - including clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
