On 5/3/2010 11:29 AM, Steve Simmons wrote: > > On Apr 19, 2010, at 9:17 AM, Sanket Agarwal wrote: > >> Here's the gerrit change id: http://gerrit.openafs.org/#change,1777 >> >> Here's the output from my machine: > > I've been looking this change over as a guideline to doing a csv version > of it, and wonder if we're headed a bit down the wrong implementation path. > > With this patch vos.c now has a series of if-then-elsif sections that > call a pair of functions DisplayFormatFOO and EnumberateEntryFOO for the > various FOO output formats. If we ever change/add data, we'll have to go > into each of these output function types individually and add the > appropriate changes. To me it makes more sense to call a single pair of > functions, eg, DisplayByFormat and EnumerateEntryByFormat and hand them > a flag indicating the desired output format. This will simplify the > upper levels of vos.c, isolate it from any future format > changes/additions, and ensures that if any fix/update is made to > DisplayByFormat or EnumeratreEntryByFormat, all the formats are going to > be corrected at the same time. > > I'm going ahead with a csv patch that mirrors the way Sanket did the xml > one, but if both are accepted I'll take on the work of refactoring it > into what is in above paragraph. > > Steve
Steve: I think you are correct. If you don't mind, please refactor first and then start to fill in format options. Along that line of thinking it would probably be best to have a global "-format <type>" option instead of -xml, -csv, etc. Jeffrey Altman
smime.p7s
Description: S/MIME Cryptographic Signature
