David C. Lonie wrote: > Recently, it seems that every time I pull trunk, I have to fix several > errors just to get it to compile. Does OB have a > "test-before-you-commit" policy? If not, it might be a good idea. At > the moment there are several obvious errors in trunk that, IMHO should > never have been committed. > > Has anyone else had this problem? I understand that trunk has > experimental features that may not work properly, but they should at > least compile...
Could you say what is wrong? I already feel guilty enough to correct anything faulty in what I have committed, but need to know what the error are. The trunk code is compiled on at least two compilers, on several operating systems, built using two or more build systems, sometimes in a variety of configurations. Most developers do not have all these available to test before they commit. So it is inevitable that minor differences will prevent error-free building from time to time in the trunk code. Recent examples are: the use of uint, which will not compile in Visual C++; std::tr1::shared_ptr which may be declared in <memory> <tr1/memory> or a Boost library depending on your system, but it is difficult to test all of them on one computer. If a "test-before-you-commit" policy requires the developer to download a new copy of the SVN repository after each commit and build it from scratch, I am not in favour. The time this would take is not justified with the uncritical nature of OB. It would not solve many of the problems. If you meant have a set of tests which should validate before any commit, I agree this would be a good idea, but this also would not ensure compatibility. If you want to use development code I think you should expect to correct errors. If you don't have write access, a brief note to this list, with a patch or a copy of the error messages would be helpful. Chris ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ OpenBabel-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbabel-devel
