David Lonie wrote: But if the errors in the diff I've attached work with ANY > compiler, I'd be amazed. this isn't compiler compatibility, this is > just bad code that wasn't compiled before committing.
It compiles ok on my system. However, from the diff I can see four problems: In painter.h. is missing: #ifndef OBDEPICT #define OBDEPICT #endif (OBDEPICT is defined in babelconfig.h under Windows) In the declaration of FastSearchFormat::AddPattern() includes the scope FastSearchFormat::. This should not be there but unfortunately is a form accepted by Visual C++ without any warning. There seems to be something going wrong in alias.h/alias.cpp, possibly the conditional #include for gcc, which I can't test. Have you an error message? Similarly I don't understand the error in cmlformat.cpp caused presumably by adding to an enum in base.h. With the first change it compiles for me with CMake (Visual Studio form). These are compiler/build system problems, and I agree with Geoff that everybody using CMake would help. However the Visual Studio form needs more work and already the CMakeList.txt file have quite a number of system dependent sections, so it will not guarantee compatibility. Chris ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ OpenBabel-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbabel-devel
