Alessandro Razeto wrote:
On Mon, Jan 05, 2004 at 14:16:20 +0100, Michael Bell <[EMAIL PROTECTED]> wrote:

Index: src/web-interfaces/ca/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ca/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/ca/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ca/Makefile 8 Dec 2003 16:20:16 -0000 1.2
@@ -61,7 +61,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@ $(DEST_CA_CGI_CONFDIR)/${ca_prefix}.conf.template; \
- $(LN_S) $(DEST_CA_CGI_CONFDIR)/${ca_prefix}.conf $(DEST_CA_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${ca_prefix}.conf $(DEST_CA_CGI_CONFDIR)/common.conf; \
fi


$(COOKIE_DIR)::

This is definitely wrong!!! You create a symlink into the source directory. If you remove the sources from the system then the code doesn't work.

I do not agree ! :-D The "ln foo /etc/bar" creates the symlink /etc/bar which points to /etc/foo. So it's fine.

I should read manuals more carefully. Fixed and commited to CVS.


Index: src/web-interfaces/ca/cmds/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ca/cmds/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- src/web-interfaces/ca/cmds/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ca/cmds/Makefile 18 Dec 2003 09:19:47 -0000
@@ -89,7 +89,10 @@
viewCSR \
viewCert \
viewSignature \
- warnExpiring
+ warnExpiring \
+ lists \
+ approveCSRnotSigned \
+ approveCSR


CMDS = $(AC_CMDS) $(STATIC_CMDS)

This is wrong too because lists is only present on the public interface. If a CA interface reports a missing command lists then this is a software bug of OpenCA. CSRs are never approved on the CA. The wrong button was removed.

Well list is needed IMHO because when I create the initial ca admin before issue there is a link which is broken without list.

I removed the link and changed the prose. Commited to CVS too.


Michael
--
-------------------------------------------------------------------
Michael Bell                   Email: [EMAIL PROTECTED]
ZE Computer- und Medienservice            Tel.: +49 (0)30-2093 2482
(Computing Centre)                        Fax:  +49 (0)30-2093 2704
Humboldt-University of Berlin
Unter den Linden 6
10099 Berlin                   Email (private): [EMAIL PROTECTED]
Germany                                       http://www.openca.org



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
OpenCA-Devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/openca-devel

Reply via email to