now the comments for the patch ...
Alessandro Razeto wrote:
Index: src/common/etc/openca_start.template.in
Already fixed.
Index: src/common/lib/functions/initServer
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/common/lib/functions/initServer,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/common/lib/functions/initServer 8 Dec 2003 13:08:32 -0000 1.1.1.1
+++ src/common/lib/functions/initServer 8 Dec 2003 13:20:54 -0000 1.2
@@ -5,9 +5,13 @@
## Flush the output
$|=1;
-use strict qw (@ISA);;
+use strict;
+use vars qw(@ISA);
no warnings;
+
+our ($LANGUAGE, $performance_test, @performance);
+
## start performance accounting
resetPerformancePoints ();
@@ -384,7 +388,7 @@
sub setLanguage
{
- our $LANGUAGE = $_[0];
+ $LANGUAGE = $_[0];
setlocale(LC_MESSAGES, $LANGUAGE);
bindtextdomain("openca", $AUTOCONF{"lib_prefix"}."/locale");
textdomain("openca");
@@ -400,11 +404,11 @@
sub resetPerformancePoints
{
- our $performance_test = 0;
+ $performance_test = 0;
## activate the commented line if you want to use performance counters
## use Time::HiRes qw (tv_interval gettimeofday);
return 1 if (not $performance_test);
- our @performance = (); + @performance = (); setPerformancePoint ("start time");
}
Are these changes necessary for Perl 5.8.2 really? Did you test an actual snapshot later than 2003-Dev-18? It works on my Perl 5.8.1 but the version from 20031124 doesn't work with 5.8.1 too.
Index: src/web-interfaces/ca/Makefile> Index: src/web-interfaces/ldap/Makefile
> Index: src/web-interfaces/node/Makefile (no conf file at all after the > patch)
> Index: src/web-interfaces/pub/Makefile
> Index: src/web-interfaces/ra/Makefile
> Index: src/web-interfaces/scep/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ca/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/ca/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ca/Makefile 8 Dec 2003 16:20:16 -0000 1.2
@@ -61,7 +61,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@ $(DEST_CA_CGI_CONFDIR)/${ca_prefix}.conf.template; \
- $(LN_S) $(DEST_CA_CGI_CONFDIR)/${ca_prefix}.conf $(DEST_CA_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${ca_prefix}.conf $(DEST_CA_CGI_CONFDIR)/common.conf; \
fi
$(COOKIE_DIR)::
This is definitely wrong!!! You create a symlink into the source directory. If you remove the sources from the system then the code doesn't work.
Index: src/web-interfaces/ca/cmds/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ca/cmds/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- src/web-interfaces/ca/cmds/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ca/cmds/Makefile 18 Dec 2003 09:19:47 -0000
@@ -89,7 +89,10 @@
viewCSR \
viewCert \
viewSignature \
- warnExpiring
+ warnExpiring \
+ lists \
+ approveCSRnotSigned \
+ approveCSR
CMDS = $(AC_CMDS) $(STATIC_CMDS)
This is wrong too because lists is only present on the public interface. If a CA interface reports a missing command lists then this is a software bug of OpenCA. CSRs are never approved on the CA. The wrong button was removed.
I hope you are not too much frustrated but we also try to find bugs and sometimes we find and fix some :)
Michael -- ------------------------------------------------------------------- Michael Bell Email: [EMAIL PROTECTED] ZE Computer- und Medienservice Tel.: +49 (0)30-2093 2482 (Computing Centre) Fax: +49 (0)30-2093 2704 Humboldt-University of Berlin Unter den Linden 6 10099 Berlin Email (private): [EMAIL PROTECTED] Germany http://www.openca.org
------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ OpenCA-Devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/openca-devel
