Hello Klaus, comments below Klaus Heinrich Kiwi wrote: > -# > -# s390 tokens > -# > - > -# The ica token is enabled by default on s390 > -if [[ $s390 -eq 1 ]]; then > - > I see this check removed and and can't see $s390 being read anywhere else, am I wrong to say that now the ICA token isn't being built by default only on s390 anymore? > +dnl --- with_xcryptolinz > +XCRYPTOLINZ_CFLAGS= > +XCRYPTOLINZ_LIBS= > +if test "x$with_xcryptolinz" != "xno"; then > + if test "x$with_xcryptolinz" != "xyes" -a "x$with_xcryptolinz" != > "xcheck"; then > + XCRYPTOLINZ_CFLAGS="-I$with_xcryptolinz" > + XCRYPTOLINZ_LIBS="-L$with_xcryptolinz" > + fi > + old_cflags="$CFLAGS" > + old_libs="$LIBS" > + CFLAGS="$CFLAGS $XCRYPTOLINZ_CFLAGS" > + LIBS="$LIBS $XCRYPTOLINZ_LIBS" > +dnl - The above may not be necessary since opencryptoki brings this header > file anyway. > + AC_CHECK_HEADER([csulincl.h], [], [ > + if test "x$with_xcryptolinz" != "xcheck"; then > + AC_MSG_ERROR([Build with xcryptolinz requested but > xcryptolinz headers couldn't be found]) > + fi > + with_xcryptolinz=no > + ]) > + if test "x$with_xcryptolinz" != "xno"; then > + AC_CHECK_LIB([csulsapi], [CSNBKTC], > + [with_xcryptolinz=yes], [ > If xcryptolinz lib was found, we can conclude that the user will probably want pkcscca_migrate, and also the CCA token to be built, what about enforcing it here? > CFLAGS="$CFLAGS -DPKCS64 \ > @@ -300,9 +613,7 @@ AC_OUTPUT([Makefile usr/Makefile \ > usr/sbin/Makefile \ > usr/sbin/pkcsslotd/Makefile \ > usr/sbin/pkcs11_startup/Makefile \ > - usr/sbin/pkcs11_startup/pkcs11_startup \ > usr/sbin/pkcs_slot/Makefile \ > - usr/sbin/pkcs_slot/pkcs_slot \ > usr/sbin/pkcsconf/Makefile \ > usr/sbin/pkcscca_migrate/Makefile \ > usr/lib/pkcs11/methods/Makefile \ > @@ -321,7 +632,6 @@ AC_OUTPUT([Makefile usr/Makefile \ > usr/lib/pkcs11/cca_stdll/tok_struct.h \ > usr/lib/pkcs11/methods/4758_status/Makefile \ > misc/Makefile \ > - misc/pkcsslotd \ > I probably need to read the other patches to understand why these was removed. > testcases/Makefile \ > testcases/common/Makefile \ > testcases/driver/Makefile \ > That's it, by the way, nice work refactoring/cleaning this up!
Thanks, Rajiv Andrade IBM LTC Security Development ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
