On 09/30/2009 10:50 AM, Rajiv Andrade wrote: >> So I'm defining all AC_ARG_ENABLE() macros the same way for all >> architectures, and using<root>/usr/lib/pkcs11/Makefile.am choose >> between building ica_stdll and ica_s390_stdll (btw, it's also my >> intention to remove ica_stdll and move ica_s390_stll in it's place in >> the future, since I don't see a reason for two versions) >> > I was actually asking about what it implemented and was removed, not > defending the _code_ itself, I might say additionally that I agree with > the uniform layout it (the code) is getting. My point is: if configure > script detects that libica is installed on the machine, the ica token > compilation must be enabled automatically. It would save us support > time. Also, the architecture handling isn't a big deal indeed, the > libica installation would already handled that.
I see your point. I was thinking that making the user explicitly enable/disable the tokens at build time would save us support time, but I also see the value in trying to do things automagically. Enabling the tokens when the relevant libraries are found should not be a huge change to the current code (although my fear is that it won't be as well organized as of the current patch). My suggestion would be to add a "summary" screen right after configure is run to summarize which features are enabled and which aren't. I'd prefer doing this as a follow-on patch after this huge chunk I sent you (26 parts!) is committed somewhere (even if it's a experimental branch), but I can also make the change in the current series (should be contained to patch 26/26) and re-send. What is your preference? >> >> I'll send the second revision for this batch and if it's too much for >> one shot we can discuss splitting them. >> >> Thanks for the review, > I've already got the context, splitting it now wouldn't help that much, > at least for me. Sorry, too late - As you probably noticed, already sent your way this 26-part patch :( We can meet and review the code step-by-step if desirable. -Klaus -- Klaus Heinrich Kiwi | [email protected] | http://blog.klauskiwi.com Open Source Security blog : http://www.ratliff.net/blog IBM Linux Technology Center : http://www.ibm.com/linux/ltc ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
