On Fri, 15 May 2020 at 11:22, Robert Yang <[email protected]> wrote: > > > On 5/15/20 6:16 PM, Paul Barker wrote: > > On Fri, 15 May 2020 at 10:57, Robert Yang <[email protected]> wrote: > >> > >> Set it to 0 can make it archive all the used sources during the build, > >> nothing > >> will be filtered out, this is useful when we want to archive all the > >> sources. > >> > >> This equals to: > >> COPYLEFT_LICENSE_INCLUDE = "*" > >> COPYLEFT_LICENSE_EXCLUDE = "" > >> > >> But there are a lot of settings in copyleft_filter.bbclass, so it may not > >> work > >> when its default settings are changed, add the var ENABLE_COPYLEFT_FILTER > >> will > >> make it more reliable. > > > > Why would copyleft_filter.bbclass not work when the settings are > > changed? They're intended to be configurable. > > > > I've been using `COPYLEFT_LICENSE_INCLUDE = "*"` in several projects > > for years now. I'm not sure that we need another overlapping variable > > which could confuse users further. > > As you know, there other settings in copyleft_filter.bbclass may affect > the result, such as: > > COPYLEFT_RECIPE_TYPES > COPYLEFT_PN_INCLUDE > COPYLEFT_PN_EXCLUDE > > These settings maybe changed, and it's not easy to detect the changes, > the ENABLE_COPYLEFT_FILTER can make it more reliable.
I still don't think I understand sorry. Why can't changes be detected? What's unreliable in the existing code? Are there specific failure cases we can give examples of? I think there's a good argument for renaming copyleft_filter.bbclass and all the variables since the names are confusing when you want the archiver to include non-copyleft packages. But that would cause churn and break lots of people's configs so I've never proposed it. Not sure we need a master variable to enable/disable the whole class though. Thanks, Paul
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138324): https://lists.openembedded.org/g/openembedded-core/message/138324 Mute This Topic: https://lists.openembedded.org/mt/74224037/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
