> -----Original Message----- > From: [email protected] <openembedded- > [email protected]> On Behalf Of Adrian Bunk > Sent: den 2 juni 2020 07:55 > To: Peter Kjellerstedt <[email protected]> > Cc: Alexander Kanavin <[email protected]>; openembedded- > [email protected] > Subject: Re: [OE-core] [PATCH 65/70] libyaml: adjust license checksum to > omit copyright year lines. > > On Mon, Jun 01, 2020 at 10:12:16PM +0000, Peter Kjellerstedt wrote: > > > -----Original Message----- > > > From: [email protected] <openembedded- > > > [email protected]> On Behalf Of Alexander Kanavin > > > Sent: den 31 maj 2020 17:53 > > > To: [email protected] > > > Cc: Alexander Kanavin <[email protected]> > > > Subject: [OE-core] [PATCH 65/70] libyaml: adjust license checksum to omit > > > copyright year lines. > > > > Eh, what? That's definitely not the right thing to do. For a license > > that says "The above copyright notice and this permission notice shall > > be included in all copies or substantial portions of the Software.", > > removing the copyright information makes the file useless as part of, > > e.g., ${PN}-lic. > > This is not what the patch does. > > >... > > > -LIC_FILES_CHKSUM = "file://License;md5=7bbd28caa69f81f5cd5f48647236663d" > > > +LIC_FILES_CHKSUM = > > > "file://License;md5=51591594753f05018680f6db765d5a46;beginline=3" > >... > > It only excludes the first lines from the checksum.
Which means the lines with the copyright statements will also be excluded from the file that is included with the copied license files. This behavior is what we want, since when using a license statement from a source file, you typically do not want the whole of the source file to be included with the copied license files, only the part specified in LIC_FILES_CHKSUM. But it also means the copyright information needs to be included in that part. See commit 515f4c12 for when this was introduced three years ago. > > //Peter > > cu > Adrian //Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139080): https://lists.openembedded.org/g/openembedded-core/message/139080 Mute This Topic: https://lists.openembedded.org/mt/74584232/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
