Good catch Peter.
Checksum mismatch for copyright year may sound benign but we really need
to know the changes even if its just copyright year change these
are recorded and part of license text, so its important in general to
keep this check strict like it is without this patch. So dropping this
patch is right thing to do.
On 6/2/20 1:27 AM, Alexander Kanavin wrote:
Right, in that case this commit should indeed be dropped or reverted.
Alex
On Tue, 2 Jun 2020 at 09:39, Peter Kjellerstedt
<[email protected] <mailto:[email protected]>> wrote:
If you have COPY_LIC_DIRSenabled, the license files (the ones listed
in LICENSEand the (parts) listed in LIC_FILES_CHKSUM) will be
included in the generated image by license_image.bbclass. Extraction
of the license information is handled by license.bbclass, which also
is responsible for creating ${PN}-lic packages if
LICENSE_CREATE_PACKAGEis set.____
__ __
//Peter____
__ __
*From:*Alexander Kanavin <[email protected]
<mailto:[email protected]>>
*Sent:* den 2 juni 2020 09:30
*To:* Peter Kjellerstedt <[email protected]
<mailto:[email protected]>>
*Cc:* [email protected]
<mailto:[email protected]>
*Subject:* Re: [OE-core] [PATCH 65/70] libyaml: adjust license
checksum to omit copyright year lines.____
__ __
On Tue, 2 Jun 2020 at 00:12, Peter Kjellerstedt
<[email protected] <mailto:[email protected]>>
wrote:____
> -----Original Message-----
> From: [email protected]
<mailto:[email protected]> <openembedded-
> [email protected]
<mailto:[email protected]>> On Behalf Of Alexander Kanavin
> Sent: den 31 maj 2020 17:53
> To: [email protected]
<mailto:[email protected]>
> Cc: Alexander Kanavin <[email protected]
<mailto:[email protected]>>
> Subject: [OE-core] [PATCH 65/70] libyaml: adjust license
checksum to omit
> copyright year lines.
Eh, what? That's definitely not the right thing to do. For a
license
that says "The above copyright notice and this permission notice
shall
be included in all copies or substantial portions of the
Software.",
removing the copyright information makes the file useless as
part of,
e.g., ${PN}-lic.____
__ __
As far as I understand, the extracts from LIC_FILES_CHKSUM are not
used in copies or substantial portions of the software,____
they are used in tmp/deploy/licenses (which is neither). Is it
beneficial to have the copyright years and owners____
there? The idea behind dropping them is that we can avoid continuous
adjusting of the checksum on version updates.____
__ __
If you archive the source code, or install binaries to the target,
this mechanism is not involved.____
__ __
I am not aware of ${PN}-lic, can you please point where that is
defined?____
__ __
Alex____
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#139238):
https://lists.openembedded.org/g/openembedded-core/message/139238
Mute This Topic: https://lists.openembedded.org/mt/74584232/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
