Right, in that case this commit should indeed be dropped or reverted. Alex
On Tue, 2 Jun 2020 at 09:39, Peter Kjellerstedt <[email protected]> wrote: > If you have COPY_LIC_DIRS enabled, the license files (the ones listed in > LICENSE and the (parts) listed in LIC_FILES_CHKSUM) will be included in > the generated image by license_image.bbclass. Extraction of the license > information is handled by license.bbclass, which also is responsible for > creating ${PN}-lic packages if LICENSE_CREATE_PACKAGE is set. > > > > //Peter > > > > *From:* Alexander Kanavin <[email protected]> > *Sent:* den 2 juni 2020 09:30 > *To:* Peter Kjellerstedt <[email protected]> > *Cc:* [email protected] > *Subject:* Re: [OE-core] [PATCH 65/70] libyaml: adjust license checksum > to omit copyright year lines. > > > > On Tue, 2 Jun 2020 at 00:12, Peter Kjellerstedt < > [email protected]> wrote: > > > -----Original Message----- > > From: [email protected] <openembedded- > > [email protected]> On Behalf Of Alexander Kanavin > > Sent: den 31 maj 2020 17:53 > > To: [email protected] > > Cc: Alexander Kanavin <[email protected]> > > Subject: [OE-core] [PATCH 65/70] libyaml: adjust license checksum to omit > > copyright year lines. > > Eh, what? That's definitely not the right thing to do. For a license > that says "The above copyright notice and this permission notice shall > be included in all copies or substantial portions of the Software.", > removing the copyright information makes the file useless as part of, > e.g., ${PN}-lic. > > > > As far as I understand, the extracts from LIC_FILES_CHKSUM are not used in > copies or substantial portions of the software, > > they are used in tmp/deploy/licenses (which is neither). Is it beneficial > to have the copyright years and owners > > there? The idea behind dropping them is that we can avoid continuous > adjusting of the checksum on version updates. > > > > If you archive the source code, or install binaries to the target, this > mechanism is not involved. > > > > I am not aware of ${PN}-lic, can you please point where that is defined? > > > > Alex >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139083): https://lists.openembedded.org/g/openembedded-core/message/139083 Mute This Topic: https://lists.openembedded.org/mt/74584232/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
