Hi Alex and Denys,
On 6/10/20 5:50 AM, Denys Dmytriyenko wrote:
+1
The commit message should explain "why" and not "what", as "what" can be
easily understood from the code itself.
In fact, the DISTRO_FEATURES setting shouldn't affect native build.
Initially this patch is used to fix below error when opengl not defined
in DISTRO_FEATURES in my build environment.
$ bitbake virglrenderer-native
virglrenderer-native was skipped: missing required distro feature
'opengl' (not in DISTRO_FEATURES)
And the value defined in DISTRO_FEATURES is only translated to the
appropriate option supplied to the configure script during the
do_configure task for recipes built for the target.
Thanks,
Mingli
Sometimes "why" is obvious - e.g. version update of CVE fix, but in many cases
it's not at all clear why do you want everyone to be affected by your change.
PS. https://xkcd.com/1296/
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#139386):
https://lists.openembedded.org/g/openembedded-core/message/139386
Mute This Topic: https://lists.openembedded.org/mt/74769506/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
