On 1/29/22 02:06, Peter Kjellerstedt wrote:
-----Original Message-----
From: [email protected] <openembedded-
[email protected]> On Behalf Of Marek Vasut
Sent: den 29 januari 2022 01:29
To: [email protected]
Cc: Marek Vasut <[email protected]>; Andrej Valek <[email protected]>;
Richard Purdie <[email protected]>
Subject: [OE-core] [PATCH] Revert "featimage: refactor style"
This reverts commit f44bb458884da64356ee188917094b5515d3b159.
The reverted patch attempted to perform some sort of clean up, however
it only brought in style inconsistencies like this:
```
conf_desc="$conf_desc${sep}setup"
```
The curly brackets around variables were placed in the kernel-fitimage
bbclass deliberately, since when assembling the fitimage ITS there are
multiple variables where it is difficult to identify where the variable
ends and some sort of follow up string starts.
There is actually a technical reason to not use ${foo} for shell
variables unless necessary in bitbake files and it is because
bitbake will treat them all as potential bitbake variables. This
means they are unnecessarily included in the taskhashes that
bitbake calculates.
Yikes. (it would be good to include this gem in the commit message)
So are we stuck with this inconsistent coding style change or is there a
third alternative ? I mean, besides rewriting the fitimage generation
into python, which might make it more flexible too.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161090):
https://lists.openembedded.org/g/openembedded-core/message/161090
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
