On 1/29/22 03:01, Peter Kjellerstedt wrote:
Hi,
[...]
Personally I do not see it as inconsistent, it is just the way
shell handles variables. It is just something to get used to (I
also had a colleague who would review any shell code changes we
made and comment on every single unnecessary character so one
quickly learned to use $foo everywhere possible rather than
${foo}...)
On the other hand, once you get burnt ${foo}bar / $foobar , you might
quickly start putting the {} everywhere. That's my case.
(we should likely stop this ^ discussion thread before it turns into a
flamewar)
That said, I have never looked at this code so I
have no real idea of how bad it is or isn't.
This patch lists pretty much all the vars, so you can get a pretty
decent idea from just looking at that.
third alternative ? I mean, besides rewriting the fitimage
generation into python, which might make it more flexible too.
Replacing shell code that has grown beyond a couple of hundred
(tens?) lines with something written in a better language is
almost always a good idea.
It's grown to almost 800 LoC, so maybe it is time to reevaluate the
python conversion then.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161094):
https://lists.openembedded.org/g/openembedded-core/message/161094
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
