On 1/31/22 08:01, Valek, Andrej wrote:
Hi,
Hello Andrej,
(please avoid top-posting)
Sorry, but personally I don't like your idea. What's the benefit of
reverting this? I would keep the ${} for bitbake and $ for shell. The
{} has to be placed only for variables like $a${b}c.
That's exactly the benefit of using ${} in shell scripts consistently --
you don't have to worry about variable names being accidentally
conflated with surrounding strings, either due to your own mistake, or
some automated transformation that was applied incorrectly .
We should respect the workflow on all recipes otherwise we're braking
the "unwritten" rules.
The workflow on all recipes ? What does this mean ?
The "unwritten" rules ? If they are unwritten, of course they will be
broken by people. Better update the documentation.
There is one technical counter-argument to this revert from Peter, quote:
"
There is actually a technical reason to not use ${foo} for shell
variables unless necessary in bitbake files and it is because
bitbake will treat them all as potential bitbake variables. This
means they are unnecessarily included in the taskhashes that
bitbake calculates.
"
But the patch being reverted here addresses the problem only partly,
because it still contains remnants like this:
"
conf_desc="$conf_desc${sep}setup"
"
[...]
third alternative ? I mean, besides rewriting the fitimage
generation into python, which might make it more flexible too.
Replacing shell code that has grown beyond a couple of hundred
(tens?) lines with something written in a better language is
almost always a good idea.
It's grown to almost 800 LoC, so maybe it is time to reevaluate the
python conversion then.
So a rewrite into something more suitable might be a good idea ^ ,
probably python in this case.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161120):
https://lists.openembedded.org/g/openembedded-core/message/161120
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
