Hi, Alex

> It would help if you show the actual content that is being fixed. E.g.
> the problematic line in the header:
> - before the fixing
> - after being processed with oe_multilib_header
> - after being fixed with sed.

I have submitted the v3 patch with above content. Please have a look. 


Best regards
Lei



> -----Original Message-----
> From: [email protected]
> <[email protected]> On Behalf Of Alexander
> Kanavin
> Sent: Wednesday, April 24, 2024 4:38 PM
> To: Lei, Maohui <[email protected]>
> Cc: [email protected]
> Subject: Re: [OE-core][PATCH v2] libbsd: Fix conflict error when enable 
> multilib.
> 
> It would help if you show the actual content that is being fixed. E.g.
> the problematic line in the header:
> - before the fixing
> - after being processed with oe_multilib_header
> - after being fixed with sed.
> 
> Otherwise I still don't quite understand what is happening.
> 
> Alex
> 
> On Wed, 24 Apr 2024 at 04:08, Maohui Lei (Fujitsu) <[email protected]>
> wrote:
> >
> > Ping
> >
> >
> >
> > > -----Original Message-----
> > > From: [email protected]
> > > <[email protected]> On Behalf Of leimaohui
> > > via lists.openembedded.org
> > > Sent: Friday, April 19, 2024 9:16 AM
> > > To: Alexander Kanavin <[email protected]>
> > > Cc: [email protected]
> > > Subject: Re: [OE-core][PATCH v2] libbsd: Fix conflict error when enable
> multilib.
> > >
> > > Hi, Alex
> > >
> > > > Can you explain a bit more? Why and how is it not correct? Why
> > > > isn't a similar fix needed in other uses of oe_multilib_header?
> > >
> > > Reference to https://man.archlinux.org/man/libbsd.7, by default,
> > > libbsd is built in an overlay mode, the includes in this case should
> > > be the usual system ones, such as <unistd.h> without namespaced with bsd/.
> > > It seems that libbsd is special.
> > >
> > > Best regards
> > > Lei
> > >
> > >
> > > > -----Original Message-----
> > > > From: Alexander Kanavin <[email protected]>
> > > > Sent: Thursday, April 18, 2024 1:33 PM
> > > > To: Lei, Maohui <[email protected]>
> > > > Cc: [email protected]
> > > > Subject: Re: [OE-core][PATCH v2] libbsd: Fix conflict error when enable
> multilib.
> > > >
> > > > On Thu, 18 Apr 2024 at 03:23, leimaohui via lists.openembedded.org
> > > > <[email protected]> wrote:
> > > > > - The path of cdefs-64.h and cdefs-32.h in cdefs.h is not
> > > > > correct for libbsd after
> > > > enable oe_multilib_header on cdefs.h. It is necessary to fix the path.
> > > > > +do_install:append () {
> > > > > +       oe_multilib_header bsd/sys/cdefs.h
> > > > > +       sed -i 's:#include <bsd/sys/cdefs:#include <sys/cdefs:g'
> > > > > +${D}${includedir}/bsd/sys/cdefs.h
> > > >
> > > > Can you explain a bit more? Why and how is it not correct? Why
> > > > isn't a similar fix needed in other uses of oe_multilib_header?
> > > >
> > > > Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198695): 
https://lists.openembedded.org/g/openembedded-core/message/198695
Mute This Topic: https://lists.openembedded.org/mt/105590332/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to