No, but I will. But is this a negative point of the patch, or the autobuilder should be changed? I acted upon some personal observations, a discussion with Paul (he suggested the change) and also on this guide: https://wiki.yoctoproject.org/wiki/LSB_Result (in which distro is set to poky-lsb).
Regards, Cristian -----Original Message----- From: Richard Purdie [mailto:[email protected]] Sent: Monday, March 31, 2014 12:58 PM To: Iorga, Cristian Cc: [email protected] Subject: Re: [OE-core] [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature On Mon, 2014-03-31 at 12:51 +0300, Cristian Iorga wrote: > core-image-lsb only gave a warning: > "WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM > won't work correctly" > when the proper DISTRO was not set for it. > default choice would be DISTRO = "poky-lsb", but not necessarily, > depending on each custom distro. > > This fix will enforce the proper usage of pam as a distro feature for > core-image-lsb by giving an error instead of just a warning. > > Fixes [YOCTO #6073] > > Signed-off-by: Cristian Iorga <[email protected]> > --- > meta/recipes-extended/images/core-image-lsb.bb | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-extended/images/core-image-lsb.bb > b/meta/recipes-extended/images/core-image-lsb.bb > index ed316a6..ab61c6e 100644 > --- a/meta/recipes-extended/images/core-image-lsb.bb > +++ b/meta/recipes-extended/images/core-image-lsb.bb > @@ -9,4 +9,6 @@ IMAGE_INSTALL = "\ > packagegroup-core-lsb \ > " > > -inherit core-image > +inherit core-image distro_features_check > + > +REQUIRED_DISTRO_FEATURES = "pam" I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked? Cheers, Richard -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
