On Monday 31 March 2014 11:58:49 Stanacar, StefanX wrote: > On Mon, 2014-03-31 at 10:58 +0100, Richard Purdie wrote: > > On Mon, 2014-03-31 at 12:51 +0300, Cristian Iorga wrote: > > > core-image-lsb only gave a warning: > > > "WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, > > > PAM won't work correctly" > > > when the proper DISTRO was not set for it. > > > default choice would be DISTRO = "poky-lsb", > > > but not necessarily, depending on each custom distro. > > > > > > This fix will enforce the proper usage of pam > > > as a distro feature for core-image-lsb by giving > > > an error instead of just a warning. > > > > > > Fixes [YOCTO #6073] > > > > > > Signed-off-by: Cristian Iorga <[email protected]> > > > --- > > > > > > meta/recipes-extended/images/core-image-lsb.bb | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-extended/images/core-image-lsb.bb > > > b/meta/recipes-extended/images/core-image-lsb.bb index ed316a6..ab61c6e > > > 100644 > > > --- a/meta/recipes-extended/images/core-image-lsb.bb > > > +++ b/meta/recipes-extended/images/core-image-lsb.bb > > > @@ -9,4 +9,6 @@ IMAGE_INSTALL = "\ > > > > > > packagegroup-core-lsb \ > > > " > > > > > > -inherit core-image > > > +inherit core-image distro_features_check > > > + > > > +REQUIRED_DISTRO_FEATURES = "pam" > > > > I have a feeling the autobuilder builds core-image-lsb in situations > > where DISTRO=poky, although I could be wrong. Have you checked? > > FWIW, all the -lsb buildsets are done with DISTRO=poky-lsb on the AB. > Unfortuntely we do have one problematic build. > So the answer to your question is: we don't have core-image-lsb builds > with DISTRO=poky but we do have a lib64-core-image-lsb-sdk image built > with DISTRO=poky and no pam in DISTRO_FEATURES, see the last build on > nightly-multilib... :(
If we're doing this then we should be changing the autobuilder so it doesn't. LSB images should not be built in non-LSB configuration. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
