On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy <armccu...@gmail.com> wrote: > On Thu, May 17, 2018 at 6:56 PM, Khem Raj <raj.k...@gmail.com> wrote: >> Hi Andre >> >> This series is fine, except that it has some formatting changes mixed with >> cmake related changes. It would be preferable to have them as separate >> pulls. I reckon that both types of changes are good. > > The formatting cleanups are all minor and probably not worth > submitting on their own. >
OK thats fine, drop then in v2 >> On 5/17/18 6:30 PM, Andre McCurdy wrote: >>> >>> The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and >>> ${datadir}/cmake end up in the dev package, so recipes no longer need >>> to provide custom packaging rules to handles these files. >>> >>> >>> http://git.openembedded.org/openembedded-core/commit/?id=d91dc4666683a96e9d03cbbd21b8a546f9069c93 >>> >>> Signed-off-by: Andre McCurdy <armccu...@gmail.com> >>> --- >>> meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git >>> a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb >>> b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb >>> index 9354799..6b9c545 100644 >>> --- a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb >>> +++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb >>> @@ -24,5 +24,4 @@ PACKAGECONFIG[testapps] = >>> "-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON, >>> PACKAGES =+ "${PN}-testapps" >>> -FILES_${PN}-dev += "${libdir}/cmake" >>> FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*" >>> >> -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel