On Sat, May 19, 2018 at 12:35 PM, Trevor Woerner <twoer...@gmail.com> wrote: > On Sat, May 19, 2018 at 7:59 AM, Peter Kjellerstedt > <peter.kjellerst...@axis.com> wrote: >> >> If you do, I think you should spin the patches for the clean ups as well. >> At least I agree with (most) of them, and on a whole they definitely >> improve the recipes. >> >> And I also agree with Andre, that in general it is too much trouble to >> generate clean up patches in their own, which is why it might be better >> to allow some clean ups together with actual changes. Otherwise they will >> not happen, which in the long run deteriorate the overall state of the >> recipes. > > I'm happy to slowly go through the recipes and make formatting changes. What > is the accepted canonical order of variables and segments in a recipe file?
The OE style guide states that it should be considered the canonical reference (rather than for example contrib/oe-stylize.py): http://www.openembedded.org/wiki/Styleguide If you stick to non-controversial changes such as ordering of variables then I think it's a pretty good set of guidelines. It hasn't been updated to give ordering for PACKAGECONFIG or BBCLASSEXTEND but the conventions for those (based on recipes in oe-core) seem to be: - PACKAGECONFIG lines go between "inherit ..." and EXTRA_OECONF - BBCLASSEXTEND goes at the end of the recipe > Oh, and did we agree on tabs, or spaces? No, probably never will :-) Best approach would be to not mess with indent - unless you find a line indented with spaces between two lines indented with tabs (or vice versa). -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel