On Fri, May 18, 2018 at 6:28 PM, Andre McCurdy <armccu...@gmail.com> wrote:
> On Fri, May 18, 2018 at 2:01 PM, Khem Raj <raj.k...@gmail.com> wrote: > > On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy <armccu...@gmail.com> > wrote: > >> On Thu, May 17, 2018 at 6:56 PM, Khem Raj <raj.k...@gmail.com> wrote: > >>> Hi Andre > >>> > >>> This series is fine, except that it has some formatting changes mixed > with > >>> cmake related changes. It would be preferable to have them as separate > >>> pulls. I reckon that both types of changes are good. > >> > >> The formatting cleanups are all minor and probably not worth > >> submitting on their own. > >> > > > > OK thats fine, drop then in v2 > > They are not worth reworking the patch set to create a v2 either :-) > It would be wonderful if we could agree on formatting; if we could, I'd certainly help by taking on some of the reformatting task. Unfortunately, all such past attempts of which I'm aware never got anywhere, and if I remember correctly, the Yocto folks and the OE folks each have their own ideas of what is "correct". In any case, if these won't get in as is, if Andre doesn't want to spin a v2 without the formatting changes, and everyone is okay with it, I could spin a v2 without the formatting changes. -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
