> -----Original Message-----
> From: [email protected] <openembedded-
> [email protected]> On Behalf Of Peter Marko via
> lists.openembedded.org
> Sent: den 8 maj 2024 13:16
> To: [email protected]
> Cc: Peter Marko <[email protected]>
> Subject: [oe] [meta-oe][scarthgap][master][PATCH] re2: remove dev
> dependencies from main package
> 
> From: Peter Marko <[email protected]>
> 
> It's a bad idea to add dev dependencies to main package.
> It's pulling build dependencies including toolchain items.
> 
> The dependencies "were needed" because main package contains
> packageconfig file.
> This can be fixed by correct packaging.
> 
> Signed-off-by: Peter Marko <[email protected]>
> ---
>  meta-oe/recipes-support/re2/re2_2024.03.01.bb | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/re2/re2_2024.03.01.bb b/meta-
> oe/recipes-support/re2/re2_2024.03.01.bb
> index 192fe265f..6e5b32a94 100644
> --- a/meta-oe/recipes-support/re2/re2_2024.03.01.bb
> +++ b/meta-oe/recipes-support/re2/re2_2024.03.01.bb
> @@ -16,9 +16,6 @@ DEPENDS = "abseil-cpp
> ${@bb.utils.contains('PTEST_ENABLED', '1', 'gtest googlebe
> 
>  inherit cmake ptest
>  RDEPENDS:${PN}-ptest += "cmake sed"
> -RDEPENDS:${PN} += "abseil-cpp-dev"
> -
> -INSANE_SKIP:${PN} += "dev-deps"
> 
>  EXTRA_OECMAKE += " \
>       -DBUILD_SHARED_LIBS=ON \
> @@ -39,6 +36,6 @@ FILES:${PN} = "${libdir}"
>  INSANE_SKIP:${PN} += "dev-so"
> 
>  # Don't include so files in dev package
> -FILES:${PN}-dev = "${includedir} ${libdir}/cmake"
> +FILES:${PN}-dev = "${includedir} ${libdir}/cmake ${libdir}/pkgconfig"

This wouldn't be needed if FILES:${PN} wasn't set using 
FILES:${PN} = "${libdir}" earlier.

A better way to achieve that *.so files are packaged in the base package 
is to do:

SOLIBS = ".so*"
FILES_SOLIBSDEV = ""
INSANE_SKIP:${PN} += "dev-so"

> 
>  BBCLASSEXTEND = "native nativesdk"
> --
> 2.30.2

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#110323): 
https://lists.openembedded.org/g/openembedded-devel/message/110323
Mute This Topic: https://lists.openembedded.org/mt/105978716/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to