-----Original Message----- From: Khem Raj <[email protected]> Sent: Monday, May 13, 2024 18:37 To: Marko, Peter (ADV D EU SK BFS1) <[email protected]> Cc: Peter Kjellerstedt <[email protected]>; [email protected] Subject: Re: [oe] [meta-oe][scarthgap][master][PATCH] re2: remove dev dependencies from main package
> On Mon, May 13, 2024 at 12:07 AM Peter Marko via > lists.openembedded.org > <[email protected]> wrote: > > > > > > # Don't include so files in dev package -FILES:${PN}-dev = > > > > "${includedir} ${libdir}/cmake" > > > > +FILES:${PN}-dev = "${includedir} ${libdir}/cmake ${libdir}/pkgconfig" > > > > > > This wouldn't be needed if FILES:${PN} wasn't set using FILES:${PN} = > > > "${libdir}" earlier. > > > > > > A better way to achieve that *.so files are packaged in the base package > > > is to do: > > > > > > SOLIBS = ".so*" > > > FILES_SOLIBSDEV = "" > > > INSANE_SKIP:${PN} += "dev-so" > > > > > > > The patch is already merged, so I'm not sending a v2 anymore > > Please address the feedback in a new patch since it is an improvement, > your patch fixed an issue and was in a merge queue > that has been through a few CI cycles already, so I did not remove it, > however, that does not mean that it can not be improved upon. > https://lists.openembedded.org/g/openembedded-devel/message/110921 sent out > but thanks for the hint for my future patches. > > I wanted to do the least intrusive change as I don't understand why the > > solibsdev are needed in the main package. > > And larger reworks usually trigger those kind of discussions which I was > > not ready to answer. > > > > Peter > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#110922): https://lists.openembedded.org/g/openembedded-devel/message/110922 Mute This Topic: https://lists.openembedded.org/mt/105978716/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
