Em Ter, 2009-06-16 às 19:10 +0300, Ilya Petrov escreveu: > maby we should *fix* hci driver to make it responsible of setting UPxOCR and > suspending ports?
Heh, dont forget that the logic we are talking about here is used on ALL platforms, including X86. Its generic OHCI, and the Host Controller driver only provides some hardware specific functions to the generic code. UP3OCR is board specific, and definitely it doesn't belong to the generic part nor to the host controller part. Or you are proposing to add suspend code to the mux driver? This isn't valid, as it is already handled by the generic code. You would have to remove the suspend/resume handling from the usb generic code and this really isn't acceptable. Also, i think you are searching the fix on the wrong place. UP3OCR doesn't seem to be related to the error you are seeing on resume. Just assert that some resume callback sets UP3OCR = 2; and this should be enough. If you are worried about UP3OCR needing to be restored before the usb code tries to resume the port, move it to pxa resume code on arch/arm/mach-pxa, the code there is executed before anything else, tough I don't think that this will solve the issue. As I said earlier, other phones are resuming with BP on a working state, I tested this on a780 and e680, but this was before your changes to mux. -- Daniel Ribeiro
signature.asc
Description: Esta é uma parte de mensagem assinada digitalmente
