Of course we can wait till Monday :)
On Fri, Apr 20, 2018 at 11:02 PM, Vishal Thapar <[email protected]> wrote: > Ignore previous mail, Jamo ran GENIUS CSIT on OVSDB patch and it passed > 100%. So now we wait for MDSAL revert and follow up. > > Regards, > Vishal. > > On Sat, Apr 21, 2018 at 11:27 AM, Vishal Thapar <[email protected]> > wrote: > >> Hi Abhijit, >> >> Agree, though am worried about how long it will take this being weekend >> and all. >> >> Faseela, >> Has anyone tried the OVSDB patch with Genius CSIT, at least locally? I >> just want to be sure that this issue is not hiding some other bug and if we >> find it after all the reverts we would've lost even more time. >> >> Regards, >> Vishal. >> >> On Sat, Apr 21, 2018 at 10:52 AM, Abhijit Kumbhare <[email protected] >> > wrote: >> >>> Since we don't have a closure on the issue yet & multiple of you guys >>> are facing problems, I suggest we move on with option 1 to get folks >>> unblocked: >>> >>> >>> 1. Revert mdsal patch, along with lisp and other patches which got >>> merged to adapt to the same. >>> >>> >>> After that as I said let the weather item be done, the PTLs of dependent >>> projects review it & approve it (or raise objections/provide alternative/or >>> justify why not have the change totally). >>> >>> Please let's just move on & do the above (revert/reintroduce after >>> weather item/feedback on weather item). >>> >>> >>> On Fri, Apr 20, 2018 at 9:46 PM, Faseela K <[email protected]> >>> wrote: >>> >>>> I don’t have a problem with both the approaches, just that we need a >>>> way forward. >>>> >>>> >>>> >>>> 1. Revert mdsal patch, along with lisp and other patches which got >>>> merged to adapt to the same. >>>> >>>> OR >>>> >>>> 1. Merge ofp and ovsdb patches to see if we have any more issues in >>>> genius and netvirt CSIT. >>>> >>>> But since Anil has raised a concern on adapting the change in ofp, that >>>> discussion needs to be closed. >>>> >>>> Else, mdsal should provide a backward compatible change, so that users >>>> are free to choose what to use. >>>> >>>> If this discussion will take more time, I am not seeing any >>>> option other than 1. >>>> >>>> >>>> >>>> Thanks, >>>> >>>> Faseela >>>> >>>> >>>> >>>> *From:* Abhijit Kumbhare [mailto:[email protected]] >>>> *Sent:* Saturday, April 21, 2018 9:24 AM >>>> *To:* Vishal Thapar <[email protected]> >>>> *Cc:* Faseela K <[email protected]>; Sam Hague <[email protected]>; >>>> [email protected]; tsc < >>>> [email protected]>; [email protected]; Release >>>> <[email protected]>; Robert Varga <[email protected]>; >>>> [email protected] >>>> *Subject:* Re: [openflowplugin-dev] [integration-dev] [mdsal-dev] >>>> IMPORTANT: Build breakage in openflowplugin due IP address NoZone changes >>>> >>>> >>>> >>>> As I said earlier - the fastest thing would be for Robert & others to >>>> back out all the no zone changes from MD-SAL & other projects and unblock >>>> everyone. And then have the decision whether to have the change (after the >>>> weather report) => if +1 from the respective parties (PTLs of >>>> dependent/affected projects like you, Faseela, etc.) then add the changes >>>> back to MD-SAL & all the projects if thumbs up from PTLs. >>>> >>>> >>>> >>>> Is there any problem with the above approach? >>>> >>>> >>>> >>>> On Fri, Apr 20, 2018 at 8:45 PM, Vishal Thapar <[email protected]> >>>> wrote: >>>> >>>> Hi Sam, Faseela, >>>> >>>> >>>> >>>> Yes, we can't rule out similar issues in Genius/Netvirt, thought a good >>>> thing would be to check for use of the API. OVSDB patch should resolve the >>>> Genius issue for now. Why don't we merge it so we can test Genius CSIT. If >>>> needed, can always be reverted later. >>>> >>>> >>>> >>>> Regards, >>>> >>>> Vishal. >>>> >>>> >>>> >>>> On Sat, Apr 21, 2018 at 8:59 AM, Faseela K <[email protected]> >>>> wrote: >>>> >>>> I don’t know what the decision is yet. >>>> >>>> We are talking about outstanding patches in ofp and ovsdb. Ofp patch >>>> still has Anil’s -1. >>>> >>>> And we are saying TSC decision is to merge these pending patches. >>>> >>>> We will be broken till we get a conclusion on this, we do have a lot of >>>> pending patches in genius just awaiting CSIT results to get merged. And we >>>> are all blocked. >>>> >>>> >>>> >>>> Thanks, >>>> >>>> Faseela >>>> >>>> >>>> >>>> *From:* Sam Hague [mailto:[email protected]] >>>> *Sent:* Saturday, April 21, 2018 7:10 AM >>>> *To:* Abhijit Kumbhare <[email protected]> >>>> *Cc:* Robert Varga <[email protected]>; Faseela K <[email protected]>; >>>> tsc <[email protected]>; [email protected]; >>>> Release <[email protected]>; >>>> [email protected]; [email protected] >>>> aylight.org >>>> *Subject:* Re: [integration-dev] [mdsal-dev] [openflowplugin-dev] >>>> IMPORTANT: Build breakage in openflowplugin due IP address NoZone changes >>>> >>>> >>>> >>>> >>>> >>>> On Fri, Apr 20, 2018, 9:13 PM Abhijit Kumbhare <[email protected]> >>>> wrote: >>>> >>>> Thanks Robert (previous email responses). As I understand OVSDB and >>>> Genius are having issues making their builds work after integrating the >>>> no-zone patches. Hence revert first makes the most sense for the fastest >>>> unblocking everyone. >>>> >>>> Do we know if there is further collateral damage down the line? Meeting >>>> netvirt csit is broken from the ovsdb issue so we haven't verified if it >>>> also suffers. >>>> >>>> >>>> >>>> On Fri, Apr 20, 2018 at 5:02 PM, Robert Varga <[email protected]> wrote: >>>> >>>> On 20/04/18 18:31, Abhijit Kumbhare wrote: >>>> > Agree - it will be best to revert in my opinion & then figure out the >>>> > way forward. Especially since its breaking downstream that will take >>>> > longer. Can you guys revert it Robert or Tom? >>>> >>>> Hello Abhijit, >>>> >>>> The way I am reading the situation is that we have two outstanding >>>> patches to bring us over the hump -- OFP and OVSDB. Reverting means >>>> reverting also in bgpcep and lispflowmapping (IIRC) -- is that factored >>>> in your appraisal of the situation? >>>> >>>> Regards, >>>> Robert >>>> >>>> >>>> >>>> _______________________________________________ >>>> integration-dev mailing list >>>> [email protected] >>>> https://lists.opendaylight.org/mailman/listinfo/integration-dev >>>> >>>> >>>> >>>> _______________________________________________ >>>> openflowplugin-dev mailing list >>>> [email protected] >>>> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >>>> >>>> >>>> >>>> >>>> >>> >>> >> >
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
