> Have you uploaded branches that contained merge commits? Nope.
> Have you uploaded branches that required merging afterwards (not > rebasing / cherry-picking) to be applied? I think once a change has been +2 approved, it can be modified by at will (eg. for rebasing / fixing merge conflicts) before being pushed. This may be a problem as it relies on trust that the author doesn't do anything nefarious between getting approval and pushing. I haven't experimented with it though, so I may be wrong. >> > W4 Comment on whole review >> >> 2: Hard to do >> >> See above. Since it doesn't show the whole review, it seems unlikely to >> be >> able to comment and rate the whole review. Instead, the rating of the >> whole >> review my be achieved by analysing the dependency tree. > K: 5 > > Do you agree or disagree with my comment above? I think we have a different definition of "whole review". I defined a whole review as a single commit (a list of multiple revisions of that commit). If you have multiple commits, you can have them depend on each other but they get separate reviews. Dealing with multiple, dependent commits is annoying (fixing a base commit requires rewriting old history with lots of rebasing). Gerrit encourages larger commits, so you'd usually have a set of coherent changes in a single commit and update that commit during the review process. These will show up in the repo history as a single commit, but you can always track down the review of a commit in Gerrit to see the revision history for that commit. >> > W20 Configure notifications >> >> I think 4 or 5. Not sure though, as I have not tried this feature. > > K: 5 > > Can you tell us some more about how this works? By notifications, I assume you mean by email? Under Settings/Watched Projects, the user gets a table of checkboxes where for each "project", they can configure whether New Changes, Comments and Submitted Changes trigger a notification. "Projects" are configurable by search filtering: http://gerrit.googlecode.com/svn/documentation/2.1.6/user-search.html >> > W21 Filter reviews >> >> It has a search feature which is quite powerful: >> >> http://gerrit.googlecode.com/svn/documentation/2.1.6/user-search.html >> >> I don't understand how the dashboard feature works yet. > > K: 5 > > Can you tell us some more about this? Not sure what you want more info about besides what's covered in that webpage. The dashboard for a user shows three sections (Started by me, Reviewable by me, Recently closed [of those started/reviewed by me]). Things in Reviewable By Me are the reviews where people explicitly marked me as a reviewer, or if I provided comments in the past. >> > A1 Comment on whole review >> >> 2: Hard to do. >> >> See W4. > > K: 5 > > Did you mean the whole contribution (multiple patches) -- which is what > we > meant here -- or did you mean on the commit (which is what each review in > Gerrit is). I meant on the commit. >> > N2 Notifications should be machine readable >> >> 4: Has > > K: 5 > > Are the emails machine-readable? What did you mean as machine-readable > here? I agree with your 4. They can be scraped, but they're primarily intended for humans to read. > K: 1 > >> > N5 Filterable notifications by repo/branch >> > N6 Filterable notifications by component/path >> >> 4.5: Has, not perfect, we can live with it > > K: 5 (N5) and 1-2 (N6) > I see the feature of configuring notifications given a Gerrit search > term. Have > you tried to filter by path and failed? Actually, I didn't know about the filtering by path feature. Yes, it should be 4.5. Let me know if you have any more questions. Kevin. _______________________________________________ Opengov mailing list Opengov@qt-labs.org http://lists.qt-labs.org/listinfo/opengov
